Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small icon and appfilter changes #2138

Merged
merged 2 commits into from
Jun 1, 2024
Merged

Conversation

wwwwwwari
Copy link
Contributor

@wwwwwwari wwwwwwari commented May 27, 2024

This PR includes mostly minor changes

  1. Add several variants of Thai TV apps to use 'thai_tv.svg' icon    
  2. Adjust Comdirect PhotoTAN's icon to use outline instead of the default font - comdirect apps + sonos icon updates #2117
  3. Add missing entries for Claro Flex and Sound Meter in the appfilter.xml (icons already exist) - [help] Icon appears in website but not in my homescreen #2136

@wwwwwwari wwwwwwari changed the title Small icon and appfitler changes Small icon and appfilter changes May 27, 2024
@Donnnno
Copy link
Collaborator

Donnnno commented Jun 1, 2024

image

More minimalism™️!

Co-Authored-By: Wari <89649458+wwwwwwari@users.noreply.github.com>
@Donnnno Donnnno merged commit 833156e into Arcticons-Team:main Jun 1, 2024
1 check passed
@wwwwwwari
Copy link
Contributor Author

wwwwwwari commented Jun 1, 2024

Since the OP of the linked issue wanted them to look alike, should we also update comdirect.svg to match?

@Donnnno
Copy link
Collaborator

Donnnno commented Jun 1, 2024

Hmm that C is pretty big, so that would feel maybe too empty then?

@wwwwwwari
Copy link
Contributor Author

It'll be kind of empty, yes, but I kind of agree with the OP of that issue that the 2 icons should look the same since it's the same company's apps. I'm thinking we could do one of these:

  1. Copy the C of comdirect_phototan.svg to comdirect.svg - the comdirect icon will become kind of empty as you said
  2. Copy the C of comdirect.svg to comdirect_phototan.svg - the phototan icon will look not minimal enough (which is what you just fixed)
  3. Do 1 or 2 and add the other design as alt icons?

I'm leaning to just go with the outlines for both of them and add the thin line designs as alts - thoughts? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants