-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat: relative move improvements and other enhancements #1306
Merged
peterbarker
merged 13 commits into
ArduPilot:master
from
rmackay9:chat-relative-move-fix
Jan 12, 2024
Merged
Chat: relative move improvements and other enhancements #1306
peterbarker
merged 13 commits into
ArduPilot:master
from
rmackay9:chat-relative-move-fix
Jan 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also sanity check arguments passed from assistant
peterbarker
approved these changes
Jan 12, 2024
# sanity check arguments | ||
if type_mask == 3576: | ||
# if position is specified check lat, lon, alt are provided | ||
if "latitude" not in arguments.keys(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could iterate over a list; duplicated code
Thanks very much! |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes these enhancements:
I've tested all this fairly thoroughly in SITL. Below is a screenshot of the parameter description feature.