AP_GPS: allow logging of UBX-RXM-RTCM #26806
Open
+141
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyp1per
force-pushed
the
pr-ubx-rtcm-info
branch
from
0019658
to
7c11b32
Compare
|
nice! flight logs would be useful |
tridge
requested changes
Apr 22, 2024
libraries/AP_GPS/AP_GPS.cpp
Outdated
| // @Values: 0:Ignore,1:Always log | ||
| // @RebootRequired: True | ||
| // @User: Advanced | ||
| AP_GROUPINFO("_RTCM_DATA", 34, AP_GPS, _rtcm_data, 0), |
There was a problem hiding this comment.
we could have this as a bit in GPS_DRV_OPTIONS I think
| @@ -1633,7 +1641,7 @@ bool AP_GPS::parse_rtcm_injection(mavlink_channel_t chan, const mavlink_gps_rtcm | |||
| const uint32_t crc = crc_crc32(0, buf, len); | |||
|
|
|||
| #if HAL_LOGGING_ENABLED | |||
| AP::logger().WriteStreaming("RTCM", "TimeUS,Chan,RTCMId,Len,CRC", "s#---", "F----", "QBHHI", | |||
| AP::logger().WriteStreaming("RTKR", "TimeUS,Chan,RTCMId,Len,CRC", "s#---", "F----", "QBHHI", | |||
There was a problem hiding this comment.
we need to document this message (did I leave out docs? why didn't CI catch it?)
| rtcm.sent_idx = (rtcm.sent_idx+1) % ARRAY_SIZE(rtcm.sent_crc); | ||
|
|
||
| if (buf != nullptr && len > 0) { | ||
| #if HAL_LOGGING_ENABLED | ||
| AP::logger().WriteStreaming("RTKT", "TimeUS,Chan,RTCMId,Len,CRC", "s#---", "F----", "QBHHI", |
|
Ping @andyp1per let's not forget this one |
andyp1per
force-pushed
the
pr-ubx-rtcm-info
branch
from
fd0978d
to
794a35d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.