Global: Change division to multiplication #26855
Open
+31
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you checked the assembly output? There is a high chance the compiler is already making this optimisation. |
We don't let the compiler do this as the results can change. I think that's We can choose to do it ourselves, of course, and yes, this PR does change the compiler output to do muls rather than divs. |
peterbarker
force-pushed
the
AP_Change_division_to_multiplication-3
branch
from
b480a4e
to
a5de365
Compare
peterbarker
requested changes
Sep 30, 2024
| @@ -603,7 +603,7 @@ int decodeECU_TelemetrySlow1PacketStructure(const void* _pg_pkt, ECU_TelemetrySl | |||
|
|
|||
| // Input voltage in Volts | |||
| // Range of voltage is 0.0f to 25.5f. | |||
| _pg_user->voltage = float32ScaledFrom1UnsignedBytes(_pg_data, &_pg_byteindex, 0.0f, 1.0f/10.0f); | |||
There was a problem hiding this comment.
This is a generated file, should not be modified
There was a problem hiding this comment.
I have reverted the changes to the piccolo_protocol.
|
Can be merged once the piccolocan patches are removed |
muramura
force-pushed
the
AP_Change_division_to_multiplication-3
branch
from
a5de365
to
a0b9a90
Compare
muramura
force-pushed
the
AP_Change_division_to_multiplication-3
branch
from
a0b9a90
to
be67cd5
Compare
|
@muramura please rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The STM32 has fewer clocks for multiplication than for division.