-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copter/Plane/Rover/Tracker: add PilotPi support #28247
base: master
Are you sure you want to change the base?
Conversation
Hi @heeplr, Thanks for the contribution! I'm not really qualified to review the changes but I can see that the single commit will need to be broken up into multiple commits with each affecting just a single directory. We've got some info on this in the developer wiki here. |
I saw this but I supposed it's meant for adding multiple features to different libraries. With this PR every commit msg would be "add pilotpi support" or "enable xy for pilotpi". Should I still do it although it doesn't really ease review? |
It's fine for the commit messages to have similar titles but they should have a different prefix. So I think there should be commits with at least these prefixes:
|
Adds "pilotpi" board to support https://docs.px4.io/main/en/flight_controller/raspberry_pi_pilotpi.html
Adds "pilotpi" board to support https://docs.px4.io/main/en/flight_controller/raspberry_pi_pilotpi.html
3b74666
to
4a6ae02
Compare
@rmackay9 thank you for clarifying. I ran |
855b284
to
1aeca1a
Compare
Please consider reviewing |
Adds "pilotpi" board to support https://docs.px4.io/main/en/flight_controller/raspberry_pi_pilotpi.html
Adds "pilotpi" board to support https://docs.px4.io/main/en/flight_controller/raspberry_pi_pilotpi.html
1aeca1a
to
e57765e
Compare
Adds "pilotpi" board to support https://docs.px4.io/main/en/flight_controller/raspberry_pi_pilotpi.html