Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools: Do not use system packages on openSUSE #28273

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Tools: Do not use system packages on openSUSE #28273

wants to merge 1 commit into from

Conversation

Ryanf55
Copy link
Collaborator

@Ryanf55 Ryanf55 commented Oct 1, 2024

  • We only tested on apt, don't blindly change dev env stuff that's not tested in CI
  • The original PR was only for APT, but the dev team thought we should try it on all the scripts for consistency

Motivation: d18a2b2#commitcomment-147393965

@Ryanf55 Ryanf55 added the DevEnv label Oct 1, 2024
Ryanf55 referenced this pull request Oct 1, 2024
@Ryanf55 @peterbarker
Tools: Give ardupilot venv access to system packages
d18a2b2 
* When possible, we can use the apt-installed python packages which are
  ABI stable
* Same for the other OS's that have VENV setup scripts

Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
peterbarker
peterbarker approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ryanf55

@Jaaaky for visibility

tridge
tridge requested changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the arch use of system packages is needed. I recently tried to help someone with arch install and without this they could not install. The build of wx from pip fails

@Ryanf55
Tools: Do not use system packages on openSUSE
24da8a3 
* We only tested on apt, don't blindly change dev env stuff that's not
  tested in CI

Signed-off-by: Ryan Friedman <25047695+Ryanf55@users.noreply.github.com>
@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Oct 1, 2024

@tridge OK, arch will keep using the flag. Any users of OpenSUSE and arch - please help by adding CI for these. It makes maintenance much easier.

@Ryanf55 Ryanf55 changed the title Tools: Do not use system packages on openSUSE and Arch Tools: Do not use system packages on openSUSE Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tridge tridge tridge requested changes

@peterbarker peterbarker peterbarker approved these changes

Assignees

@peterbarker peterbarker

Labels
DevEnv MergeOnCIPass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ryanf55 @tridge @peterbarker