Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copter: Consolidate version number settings into a single definition #28448

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

muramura
Copy link
Contributor

I want to stop writing the version number in three separate places.
I will set the version number only in a definition.

TEXT MASSAGE
Screenshot from 2024-10-23 02-08-54

Binary(AUTOPILOT_VERSION)
Screenshot from 2024-10-23 02-09-22

Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've wanted to do this for years!

ArduCopter/version.h Outdated Show resolved Hide resolved
ArduCopter/version.h Show resolved Hide resolved
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to compile :-)

@muramura muramura force-pushed the AP_Consolidate_version_number_settings_into_a_single_definition branch from b678ab1 to 9f84af8 Compare October 28, 2024 09:29
@muramura
Copy link
Contributor Author

@peterbarker san.

Include the header file before defining the macro.

Screenshot from 2024-10-28 18-37-26

Screenshot from 2024-10-28 18-38-23

@muramura muramura force-pushed the AP_Consolidate_version_number_settings_into_a_single_definition branch from 9f84af8 to 28b2ebc Compare October 28, 2024 09:54
@muramura
Copy link
Contributor Author

muramura commented Nov 6, 2024

@peterbarker san
Should other products be modified as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants