Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Param Metadata - Mark more compass values as calibration and make the loop rate a range #28470

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Param Metadata - Mark more compass values as calibration and make the loop rate a range #28470

merged 2 commits into from
Nov 5, 2024

Conversation

amilcarlucas
Copy link
Contributor

No description provided.

@Hwurzburg
Copy link
Collaborator

what functional impact does this have?

peterbarker
peterbarker approved these changes Oct 27, 2024
View reviewed changes
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterbarker
Copy link
Contributor

Marking this for DevCall to make sure people are OK with the concept of a "range" for the main loop rate.

@Hwurzburg these obviously don't affect the flight code - but will be important for MethodicConfigurator and other places. It may affect the interface in MissionPlanner poorly for the range check - perhaps a slider rather than a dropdown for the main loop rate. @amilcarlucas have you checked that?

@amilcarlucas
Copy link
Contributor Author

I did not test MP, but it will improve the Methodic configurator GUI.
And this is a better fix than adding extra exception code on the GCS side.

IamPete1
IamPete1 approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@IamPete1 IamPete1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a sensible change.

@tridge tridge merged commit 12b761c into ArduPilot:master Nov 5, 2024
98 checks passed
rmackay9
rmackay9 approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@rmackay9 rmackay9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could increase the LOOP_RATE range to 800 but this is fine, txs!

@Ryanf55 Ryanf55 changed the title Fix metadata Metadata - Mark more compass values as calibration and make the loop rate a range Nov 5, 2024
@Ryanf55 Ryanf55 changed the title Metadata - Mark more compass values as calibration and make the loop rate a range Param Metadata - Mark more compass values as calibration and make the loop rate a range Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tridge tridge tridge approved these changes

@rmackay9 rmackay9 rmackay9 approved these changes

@peterbarker peterbarker peterbarker approved these changes

@IamPete1 IamPete1 IamPete1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@amilcarlucas @Hwurzburg @peterbarker @tridge @rmackay9 @IamPete1 @CraigElder