Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dds arm through external control #28609

Merged

Conversation

Ryanf55
Copy link
Collaborator

@Ryanf55 Ryanf55 commented Nov 13, 2024

Purpose

Make arming from DDS go through external control. That way, we can prevent a companion computer from arming using #28429

We want all services that control the state of the vehicle to go through external control so we can gate them in a single place.

Size (Durandal)

Binary Name      Text [B]       Data [B]     BSS (B)      Total Flash Change [B] (%)      Flash Free After PR (B)
---------------  -------------  -----------  -----------  ----------------------------  -------------------------
arducopter-heli  72 (+0.0040%)  0 (0.0000%)  0 (0.0000%)  72 (+0.0039%)                                    141248
antennatracker   0 (0.0000%)    0 (0.0000%)  0 (0.0000%)  0 (0.0000%)                                      613396
arducopter       72 (+0.0040%)  0 (0.0000%)  0 (0.0000%)  72 (+0.0039%)                                    140792
ardurover        72 (+0.0043%)  0 (0.0000%)  0 (0.0000%)  72 (+0.0043%)                                    [29](https://github.com/ArduPilot/ardupilot/actions/runs/11826461468/job/32952516727?pr=28609#step:10:30)4832
arduplane        72 (+0.0040%)  0 (0.0000%)  0 (0.0000%)  72 (+0.0040%)                                    143680
blimp            0 (0.0000%)    0 (0.0000%)  0 (0.0000%)  0 (0.0000%)                                      591472
ardusub          0 (0.0000%)    0 (0.0000%)  0 (0.0000%)  0 (0.0000%)                                      350564

Motivation

#28429 (comment)

@Ryanf55 Ryanf55 added the ROS label Nov 13, 2024
Copy link
Contributor

@tizianofiorenzani tizianofiorenzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Nov 16, 2024

@IamPete1 I'm interested in a review/merge since this touches external control.

* Prepare for external control enabled flag gating ability to arm in DDS

Signed-off-by: Ryan Friedman <25047695+Ryanf55@users.noreply.github.com>
* Prepare for external control enabled flag gating ability to arm in DDS

Signed-off-by: Ryan Friedman <25047695+Ryanf55@users.noreply.github.com>
@Ryanf55 Ryanf55 force-pushed the dds-arm-through-external-control branch from 0c892ea to feaa5a3 Compare November 17, 2024 00:10
Copy link
Member

@IamPete1 IamPete1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterbarker peterbarker merged commit 98f3f59 into ArduPilot:master Nov 17, 2024
99 checks passed
@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label Nov 17, 2024
@Ryanf55 Ryanf55 deleted the dds-arm-through-external-control branch November 17, 2024 15:45
@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Nov 17, 2024

Hi @Hwurzburg , this PR has no change in user behavior. I don't think a wiki is necessary. Are you ok if I remove the label?

@Hwurzburg Hwurzburg removed the WikiNeeded needs wiki update label Nov 17, 2024
@Hwurzburg
Copy link
Collaborator

np

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants