-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dds arm through external control #28609
Dds arm through external control #28609
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5cab947
to
0c892ea
Compare
@IamPete1 I'm interested in a review/merge since this touches external control. |
* Prepare for external control enabled flag gating ability to arm in DDS Signed-off-by: Ryan Friedman <25047695+Ryanf55@users.noreply.github.com>
* Prepare for external control enabled flag gating ability to arm in DDS Signed-off-by: Ryan Friedman <25047695+Ryanf55@users.noreply.github.com>
0c892ea
to
feaa5a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @Hwurzburg , this PR has no change in user behavior. I don't think a wiki is necessary. Are you ok if I remove the label? |
np |
Purpose
Make arming from DDS go through external control. That way, we can prevent a companion computer from arming using #28429
We want all services that control the state of the vehicle to go through external control so we can gate them in a single place.
Size (Durandal)
Motivation
#28429 (comment)