Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add receiving support for Arduino 101 #481

Closed
wants to merge 1 commit into from

Conversation

jimaobian
Copy link

Add receiving support for Arduino 101
Add F() in the serial print
Refine the macro define for esp32

Add receiving support for Arduino 101
Add F() in the serial print
Refine the macro define for esp32
@z3t0 z3t0 self-assigned this Jun 22, 2017
@z3t0 z3t0 added the New label Jun 22, 2017
@z3t0
Copy link
Collaborator

z3t0 commented Jun 22, 2017

There has not been a formal review process setup for merging new additions to this project, but I think it would also be great if we could some confirmation that this also works for other users. Though again, I have no idea who from the community has access to the hardware (Arduino 101)

@jimaobian thoughts?

@bengtmartensson
Copy link
Contributor

This PR is not compatible with PR #437. Instead, it adds yet another C pre-processor symbol to the code proper (IR_TIMER_USE_CURIE) which was exactly the problem that #437 tried to address.

#437 adds a "soft-carrier-send" which should make sending possible on all sufficiently fast boards, like the Curie.

@jimaobian
Copy link
Author

@z3t0 Yes, I agree. This PR should be a hot patch for someone who would like to use IRRemote library on Arduino 101. It should be never merged but still exist until there are better implements.

@bengtmartensson Great! It is more elegant. I'll do some review after #437 is merged into master.

z3t0 added a commit that referenced this pull request Jun 30, 2017
z3t0 added a commit that referenced this pull request Jul 2, 2017
@z3t0
Copy link
Collaborator

z3t0 commented Jul 2, 2017

@jimaobian added to the readme

@jeffjvick
Copy link

Hi, I tested this 'hot patch' on an Arduino 101 and the receive appears to be working. Unfortunately what I really need is to send.

@jimaobian have you had any chance to look at what changes are needed on top of #437 to support this? Is there any quick dirty way to send some NEC codes out? I just need something hacky to get by. Thanks.

@z3t0
Copy link
Collaborator

z3t0 commented Aug 10, 2017

I created a beta release for #437

If it is okay I would like to close this PR as a soft carrier has already been implemented in said PR.

@z3t0 z3t0 modified the milestone: 2.5.1 Aug 10, 2017
@yygcom
Copy link

yygcom commented Oct 5, 2019

I need send , Oh my god

@bengtmartensson
Copy link
Contributor

Suggest closing this PR. It is not compatible with the current code in master.

@ArminJo ArminJo closed this Jul 14, 2020
Theaninova pushed a commit to Theaninova/Arduino-IRremote that referenced this pull request Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants