Merge beta to master #653

rBrinegar · 2019-09-22T19:35:30Z

Merge beta to master.
It was an old PR, which seems to be accidentally created, but we must reuse it now.

In the newer versions of the IDE it is sufficient to simply include the Arduino.h header file. Fixes #463

It is difficult to maintain this over different architectures and also not entirely that useful. Fixes #462

Fixes #466

This reverts commit 563c82c.

This reverts commit a406f3b.

* Removed some trailing spaces in IRremote.cpp. * IRremote.cpp: fix some compiler warnings (-Wall -Wextra). Remark: braces necessitated by the macro nature of DBG_PRINTLN. * boarddefs.h: removed spurious #. Nuked trailing spaces. Credits: bengtmartensson

* Add missing "paragraph" to library.properties. * Move not-to-be-exported includes to subdirectory. Remove #include "IRremoteInt.h" from a number of files since it now does not work any more, and since IRremote.h #includes it already. This resolves #464. * Remove #include <IRremoteInt.h> from examples, too. * Make ir_Lego_PF_BitStreamEncoder.h exported (again). * Revoked fe24095 (paragraph) to keep 1-1 correspondance to #464.

* new file: Doxyfile; #461. * Doxygen related documentation to two files. (Not complete.) #461.

@bengtmartensson

Credits: @bengtmartensson

The reason for this change is that I was informed by a community member that the Pro Micro board does not have the default pin 13. This causes many issues for beginners that are not familiar with the inner workings of the library. However, I am concerned about this being a breaking change. If there are serious issues I may just end up adding a tutorial in the FAQ for beginners, informing them how they may change the default pins.

This reverts commit 20a4d97, reversing changes made to 47aadf5.

Credits: https://github.com/LarsWH Excerpt from PR: ``` Hi, I added support for 'RC5 extended' in order to make this project: https://www.instructables.com/id/Remote-Control-for-Lava-mMotion-Swing-Mounting-Bra/ The modification is working nicely in this single application. It has not been tested elsewhere. (I am new to Git and this is my first pull request ever. So please excuse me if I have messed something up) Kind regards, Lars ``` Merged #522

…beta

…oduced in beta

ArminJo · 2020-06-01T11:06:09Z

Wrong PR

z3t0 · 2020-06-09T02:10:43Z

Hi Armin! Thank you for the work on this. I've got a lot on my hands for a few weeks so I can't really commit to a specific day I'll get this done But I'll aim to work through a part of the changes every day and hopefully should have it done by mid-this week.

z3t0

I've looked at a few files and added some comments. Will go through more tomorrow!

.github/workflows/LibraryBuild.yml

Contributing.md

README.md

examples/IRrecord/IRrecord.ino

ArminJo · 2020-06-09T09:31:38Z

Thanks a lot for your very constructive approach to the review and other discussions.
I can really appreciate it, since at the same time I have other pull requests open and its a plague to discuss every line, and to see how ideologic some people can be.
I hope you understand, I am not used to express this things in english...

z3t0 · 2020-06-10T03:45:37Z

Thanks a lot for your very constructive approach to the review and other discussions.
I can really appreciate it, since at the same time I have other pull requests open and its a plague to discuss every line, and to see how ideologic some people can be.

Haha thank you! After having been on both side of reviewing and submitting MRs I've come to conclude that committers know what they're better than the reviewers! I try to just to run through the code and see if it makes sense to me, and if not just ask some clarifying questions so I can learn!

I hope you understand, I am not used to express this things in english...

Your English is perfect 💯

z3t0

I've gone through the rest of the files! It was great reading through the code 😄 It's a lot cleaner and may have fixed a number of hidden bugs as well.

Once the last few comments are resolved, I am good to merge this in!

Can I get you all to the original comment on this MR once each of you are satisfied with this MR being merged in. A "voting" system just to acknowledge that we have consensus.

README.md

ArminJo · 2020-06-10T18:17:53Z

I added a few tasks to be done after the merge and before the release in the project https://github.com/z3t0/Arduino-IRremote/projects/4
I would like to start with formatting and housekeeping, to have the master in a valid and modern state (or status?).
Since most are small changes, I would like to do them direct at the master branch (except #437)

Does anybody know how to put the tasks in a sequence or how to prioritize them?

Lets go to build the next release 😀
Regards
Armin

z3t0 · 2020-06-11T03:06:57Z

I would like to start with formatting and housekeeping, to have the master in a valid and modern state (or status?).

"state" is the correct word 😄

I added a few tasks to be done after the merge and before the release in the project https://github.com/z3t0/Arduino-IRremote/projects/4

Awesome.

Does anybody know how to put the tasks in a sequence or how to prioritize them?

I don't think there's a way to do this. But we can create additional lists and improvise so that it looks like there's priority. Also since we only have a few tasks we don't really need proper organization.

Lets go to build the next release

🎉

bengtmartensson

braces on simple ifs (1 line blocks)

This leads to misunderstandings (is no braces on complicated ifs ok?). Better is
Braces are mandatory on all if/while/do

ArminJo · 2020-06-11T10:28:18Z

This leads to misunderstandings (is no braces on complicated ifs ok?). Better is
Braces are mandatory on all if/while/do

Very good Thanks 👍
and done.

z3t0 · 2020-06-15T03:30:46Z

Okay so I've just done a quick look over everything. We are good to merge!
I'll leave it in this state for a few days in case there is anything else to be raised. Else, if @bengtmartensson and @ArminJo could just make a comment or +1 this comment then I can merge it straight away.

Great work on this @ArminJo!

bengtmartensson · 2020-06-15T07:36:30Z

From me, it is "go for launch" ... sorry "go for merge"! (I just saw an Apollo 11 movie ;-))

To get this three years old stuff finished would be great. Everything is surely not perfect, but it is not the end, rather it is a start.

I have not checked everything, not even that it compiles and runs, but my internal warning bell does not go off either.

ArminJo · 2020-06-15T08:44:25Z

For me of course it is OK to merge.

Everything is surely not perfect, but it is not the end, rather it is a start.

I totally agree 👍.
Thats my approach, 😀 see the next activities I proposed.

Does anyone know of https://github.com/crankyoldgit/IRremoteESP8266/?
And BTW, the have Doxygen, I looked at it and found it useless. IMHO. if you have it, than you should put some effort in delivering sensible content, otherwise it is useless.

z3t0 · 2020-06-16T02:55:32Z

Does anyone know of https://github.com/crankyoldgit/IRremoteESP8266/?

I recall there may have been an issue and then that lib was formed as a spinoff.

IMHO. if you have it, than you should put some effort in delivering sensible content, otherwise it is useless.

Agreed. When (if) we do add doxygen as documentation then it should be well-written. Otherwise, it's better for us to not put in the effort of making it.

Merging!

z3t0 · 2020-06-16T02:56:05Z

Ah wait nevermind, I spoke too soon! I just noticed there are resolve conflicts preventing a merge.

@ArminJo could you take a look?

bengtmartensson · 2020-06-16T07:40:02Z

Does anyone know of https://github.com/crankyoldgit/IRremoteESP8266/?

Yes. First, the ESP8266 is, despite of its popularity, IMHO not a very good board for IR. I tried it for Infrared4Ardunio, but gave up -- the link explains the rationale. (The hardware independent stuff like sending with soft carrier and receiving with polling works though). However, the successor ESP32 is very nice, and has a usable API -- actually much nicer than AVR.

The project is, as the name suggests, a fork that only supports ESP8266 (and ESP32). IIRC, things they do that the current project doesn't (it was half a year since I looked at it):

Interrupt driven reception, cf. #439,
Support for some other protocols, in particular air conditioning,

ArminJo · 2020-06-16T08:27:47Z

Fantastic, the merge is in sight.
Thanks for reviewing! 👍

Ah wait nevermind, I spoke too soon! I just noticed there are resolve conflicts preventing a merge.

@ArminJo could you take a look?

I mentioned the merge conflicts here

I included the ProMicro definitions in boarddefs.h to make merging of the pull request easier. The beta version is now OK and tested for the ProMicro (and the Leonardo too 😀 ).
The IRrecord. ini has also merge conflicts, but I also included the changes from mater into the beta version, so we can just take the beta version.

and here

Who should merge the 2 conflicting files? You can do it if you want, just keep the beta files. If not, tell me, then I will do the merge.

but is was not easy to find them even for me.

Anyway, should I merge?
I just tested it again on my local fork 😀 and it worked and CI was succesful, taking the two files from beta.

z3t0 · 2020-06-17T02:31:51Z

Anyway, should I merge?

Sure 😄

ArminJo · 2020-06-17T07:32:45Z

Sure 😄

Done.
Additionally I commited the correct version of keywords.txt.
The dev and beta brances will be deleted at the weekend.

bengtmartensson · 2020-06-17T10:40:47Z

Gr8!!

I run doxygen and put the API-documentation (just the api-doc directory renamed) available here.

This is not a commitment that I will keep it there, nor that it will be updated.

z3t0 and others added 22 commits August 10, 2017 16:57

merge #437

6793485

Added changelog info

e1768b4

Update library.properties

622e28b

Modified library.json

b0d15b6

Restructuring directory as per #464

635e8a9

Removed redundant preprocessor directives

31968a4

In the newer versions of the IDE it is sufficient to simply include the Arduino.h header file. Fixes #463

Removed blinking led

a406f3b

It is difficult to maintain this over different architectures and also not entirely that useful. Fixes #462

Removed pronto "protocol"

563c82c

Fixes #466

Revert "Removed pronto "protocol""

542516f

This reverts commit 563c82c.

Revert "Removed blinking led"

4eb95a3

This reverts commit a406f3b.

Fix #510

5bbd55c

Doxygen API documentation in the sense of #461 (#512)

e206e12

* new file: Doxyfile; #461. * Doxygen related documentation to two files. (Not complete.) #461.

Updated README.md for API doc.

c6a2fcd

Updated README.md for API doc. (#515)

d2939e2

Credits: @bengtmartensson

Merge branch 'master' of https://github.com/z3t0/Arduino-IRremote

2b3188e

Revert "Merge pull request #519 from PaulStoffregen/master"

71f6dac

This reverts commit 20a4d97, reversing changes made to 47aadf5.

Merge branch 'LarsWH-master' into beta

3ab3088

Merge branch 'beta' of https://github.com/z3t0/Arduino-IRremote into …

742f72f

…beta

z3t0 mentioned this pull request May 25, 2020

Adding more authorized contributors #525

Closed

ArminJo added 7 commits May 27, 2020 18:56

Function declarations for non Arduino IDE's

e7a208f

Added GitHub workflow

c188aac

Revert possible error in if condition not existent in master and intr…

f737aab

…oduced in beta

Bump version to 2.5.0

7513102

Tested 5 examples for AVR

52b2312

ESP32 and SAMD tests + ProMicro changes from master for easy merging

3182cd1

ProMicro and Leonardo compile tests

c6e9013

ArminJo requested a review from z3t0 June 3, 2020 08:30

ArminJo changed the title ~~Protocol addition~~ Merge beta to master Jun 3, 2020

Documentation

ffe19fa

z3t0 reviewed Jun 9, 2020

View reviewed changes

1. Review results

c7982b6

z3t0 reviewed Jun 10, 2020

View reviewed changes

README.md Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

Installation and code style documentation

5086695

bengtmartensson reviewed Jun 11, 2020

View reviewed changes

Contributing explained

9f402a4

ArminJo merged commit 1811b69 into master Jun 17, 2020

ArminJo deleted the beta branch June 24, 2020 21:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge beta to master #653

Merge beta to master #653

rBrinegar commented Sep 22, 2019 •

edited by ArminJo

Loading

ArminJo commented Jun 1, 2020 •

edited

Loading

z3t0 commented Jun 9, 2020

z3t0 left a comment

ArminJo commented Jun 9, 2020

z3t0 commented Jun 10, 2020

z3t0 left a comment

ArminJo commented Jun 10, 2020 •

edited

Loading

z3t0 commented Jun 11, 2020

bengtmartensson left a comment

ArminJo commented Jun 11, 2020

z3t0 commented Jun 15, 2020

bengtmartensson commented Jun 15, 2020

ArminJo commented Jun 15, 2020

z3t0 commented Jun 16, 2020

z3t0 commented Jun 16, 2020

bengtmartensson commented Jun 16, 2020

ArminJo commented Jun 16, 2020

z3t0 commented Jun 17, 2020

ArminJo commented Jun 17, 2020

bengtmartensson commented Jun 17, 2020

Merge beta to master #653

Merge beta to master #653

Conversation

rBrinegar commented Sep 22, 2019 • edited by ArminJo Loading

ArminJo commented Jun 1, 2020 • edited Loading

z3t0 commented Jun 9, 2020

z3t0 left a comment

Choose a reason for hiding this comment

ArminJo commented Jun 9, 2020

z3t0 commented Jun 10, 2020

z3t0 left a comment

Choose a reason for hiding this comment

ArminJo commented Jun 10, 2020 • edited Loading

z3t0 commented Jun 11, 2020

bengtmartensson left a comment

Choose a reason for hiding this comment

ArminJo commented Jun 11, 2020

z3t0 commented Jun 15, 2020

bengtmartensson commented Jun 15, 2020

ArminJo commented Jun 15, 2020

z3t0 commented Jun 16, 2020

z3t0 commented Jun 16, 2020

bengtmartensson commented Jun 16, 2020

ArminJo commented Jun 16, 2020

z3t0 commented Jun 17, 2020

ArminJo commented Jun 17, 2020

bengtmartensson commented Jun 17, 2020

rBrinegar commented Sep 22, 2019 •

edited by ArminJo

Loading

ArminJo commented Jun 1, 2020 •

edited

Loading

ArminJo commented Jun 10, 2020 •

edited

Loading