feat: D0ri123 helm container #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: LeeSeolHui <lsh81550@gmail.com>
Signed-off-by: LeeSeolHui <lsh81550@gmail.com>
D0ri123
requested review from
Jack-R-lantern,
sunyeongchoi and
shmruin
as code owners
Jack-R-lantern
requested changes
Jul 26, 2024
There was a problem hiding this comment.
현재 Dockerfile 구조로는 빌드된 이미지가 상대적으로 클 수 있어요.
Multi Stage Build에 대해 학습하고 적용하면 merge 진행하도록 하겠습니다.
There was a problem hiding this comment.
앗 도커파일에서 이미지 용량도 고려해야 하는 부분이었군욥..! 감사합니다 :)
There was a problem hiding this comment.
추가로 도커파일을 구성하면서 문득 든 궁금한 점입니다만 혹시 COPY 명령어와 RUN cp의 차이가 뭔지 여쭤봐도 될까요??
There was a problem hiding this comment.
RUN cp론 외부 filesystem에 접근 못하지 않나요??
There was a problem hiding this comment.
copy는 호스트 머신과의 컨텍스트 공유면
run cp는 빌드되고 있는 컨테이너 내부 파일시스템이거든요
There was a problem hiding this comment.
아핫 그러니깐 제 컴퓨터에 있는 파일을 복사한다고 할 때는 COPY를 써야 하는 거고,
컨테이너 내부에서 파일을 복사한다고 할 때에는 RUN cp를 사용해야 한다는게 맞는걸까요??
Signed-off-by: LeeSeolHui <lsh81550@gmail.com>
Jack-R-lantern
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
RUN cp론 외부 filesystem에 접근 못하지 않나요??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #34