-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: iamhansko helm chart #56
Conversation
04d6b2f
to
7da8285
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gpg sign이 commit에 누락된 상태에요.
commit에 gpg sign 추가가 필요해보입니다.
ports: | ||
- containerPort: "{{ .Values.service.targetPort }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
현재 이 부분에 문제가 있는것 같아요.
6a37ffc
to
33d3d2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Liveness readiness probe 다 지우고 테스트 해볼까요?
7d472e5
to
07b6906
Compare
gpg sign만 넣으면 바로 merge 하겠습니다 |
07b6906
to
a7f1d76
Compare
Signed-off-by: iamhansko <iamhansko@kakao.com>
Signed-off-by: iamhansko <iamhansko@kakao.com>
Signed-off-by: iamhansko <iamhansko@kakao.com>
Signed-off-by: iamhansko <iamhansko@kakao.com>
Signed-off-by: iamhansko <iamhansko@kakao.com>
a7f1d76
to
1c87477
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
close #55