Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: iamhansko helm chart #56

Merged
merged 5 commits into from
Jul 29, 2024

Conversation

iamhansko
Copy link
Contributor

close #55

Copy link
Member

@Jack-R-lantern Jack-R-lantern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gpg sign이 commit에 누락된 상태에요.

commit에 gpg sign 추가가 필요해보입니다.

Comment on lines 23 to 24
ports:
- containerPort: "{{ .Values.service.targetPort }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

현재 이 부분에 문제가 있는것 같아요.

@iamhansko iamhansko force-pushed the pr/2024_iamhansko branch 2 times, most recently from 6a37ffc to 33d3d2c Compare July 27, 2024 07:01
Copy link
Member

@Jack-R-lantern Jack-R-lantern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Liveness readiness probe 다 지우고 테스트 해볼까요?

@Jack-R-lantern
Copy link
Member

gpg sign만 넣으면 바로 merge 하겠습니다

Signed-off-by: iamhansko <iamhansko@kakao.com>
Signed-off-by: iamhansko <iamhansko@kakao.com>
Signed-off-by: iamhansko <iamhansko@kakao.com>
Signed-off-by: iamhansko <iamhansko@kakao.com>
Signed-off-by: iamhansko <iamhansko@kakao.com>
Copy link
Member

@Jack-R-lantern Jack-R-lantern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jack-R-lantern Jack-R-lantern merged commit 87252c2 into Argo-OSS:main Jul 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: 고현수의 서비스 컨테이너 이미지 제작
2 participants