Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 김민수 과제 제출 #58

Merged
merged 5 commits into from
Jul 29, 2024
Merged

feat: 김민수 과제 제출 #58

merged 5 commits into from
Jul 29, 2024

Conversation

Gaic4o
Copy link
Contributor

@Gaic4o Gaic4o commented Jul 28, 2024

Close #57

@Gaic4o
feat: next.js project 셋팅
65a7c2e 
Signed-off-by: Minsu <alstntorl@naver.com>
@Gaic4o
feat: 도커 파일 pnpm next.js 작성
d0e5be8 
Signed-off-by: Minsu <alstntorl@naver.com>
@Gaic4o
feat: app/api healthcheck, Gaci4o route 생성
c930767 
Signed-off-by: Minsu <alstntorl@naver.com>
@Gaic4o
feat: Helm chart 작성
8a4b9f2 
Signed-off-by: Minsu <alstntorl@naver.com>
@Gaic4o
chore: 디렉터리 파일 name 수정
5848d4d 
Signed-off-by: Minsu <alstntorl@naver.com>
Jack-R-lantern
Jack-R-lantern approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@Jack-R-lantern Jack-R-lantern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jack-R-lantern Jack-R-lantern merged commit b96354f into Argo-OSS:main Jul 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jack-R-lantern Jack-R-lantern Jack-R-lantern approved these changes

@sunyeongchoi sunyeongchoi Awaiting requested review from sunyeongchoi sunyeongchoi is a code owner

@shmruin shmruin Awaiting requested review from shmruin shmruin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: 김민수 서비스 컨테이너 이미지 제작
2 participants
@Gaic4o @Jack-R-lantern