Skip to content

Commit

Permalink
Fix nasa#381, Reuse CodeQL, Static Analysis, Format Check
Browse files Browse the repository at this point in the history
Fix nasa#381, Reuse CodeQL, Static Analysis, Format Check
  • Loading branch information
arielswalker committed Oct 27, 2021
1 parent 48cc337 commit a7ecfc6
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@

## Reusable Workflows

To reduce duplication, CodeQL Analysis, Static Analysis, and Format Checker are placed in cFS to be reused in the subrepositories.
To reduce duplication, the workflows CodeQL Analysis, Static Analysis, and Format Checker are placed in cFS to be reused in the subrepositories.

CodeQL Analysis and Static Analysis require inputs, therefore, they are called in an additional workflow in cFS to be utilized. Format checker does not need to be reused in cFS because it does not require inputs.

Provided is a diagram of the architecture of the reusable workflows.

![Reusable Workflows Architecture](cFS-Reusable-Workflows.PNG)
![Reusable Workflows Architecture](Reusable-Workflows-Architecture.PNG)

## Deprecated Build, Test, and Run
[![Deprecated Build, Test, and Run](https://github.com/nasa/cfs/actions/workflows/build-cfs-deprecated.yml/badge.svg)](https://github.com/nasa/cfs/actions/workflows/build-cfs-deprecated.yml)
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/codeql-build-reuse.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ name: Reuse CodeQl Analysis
on:
push:
pull_request:


jobs:
codeql:
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/codeql-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ jobs:
run: |
git log -1 --pretty=oneline
git submodule
- name: Checkout codeql code
uses: actions/checkout@v2
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/format-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
push:
pull_request:
workflow_call:

jobs:
#Checks for duplicate actions. Skips push actions if there is a matching or duplicate pull-request action.
check-for-duplicates:
Expand Down Expand Up @@ -64,4 +64,4 @@ jobs:
then
cat style_differences.txt
exit -1
fi
fi
1 change: 1 addition & 0 deletions .github/workflows/static-analysis-reuse.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ name: Reuse Static Analysis

on:
push:
pull_request:

jobs:
static-analysis:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/static-analysis.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
name: Static Analysis

# Run on all push and pull requests
on:
push:
pull_request:
workflow_call:
inputs:
module:
Expand Down

0 comments on commit a7ecfc6

Please sign in to comment.