Add support for dj32 #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shabbywu
reviewed
Apr 25, 2022
garnett/expressions.py
Outdated
| ): | ||
| rhs = super().resolve_expression(query, allow_joins, reuse, summarize, for_save) | ||
| def resolve_expression(self, *args, **kwargs): | ||
| print(args, kwargs) |
There was a problem hiding this comment.
should we use logging.debug instead of print?
or other flag to make this print not work at production.
e.g. settings.DEBUG in Django
There was a problem hiding this comment.
Hi @shabbywu, thanks for your review. This PR is an early state, and we'll probably remove the print statement entirely. Hope that helps.
LegoStormtroopr
force-pushed
the
dj32
branch
from
8d99d08 to
ab7b27d
Compare
|
Nice 👌 |
ben-silke
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.