-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solr helm chart PR #6
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
naveen-armedia
commented
Aug 8, 2021
•
edited
Loading
edited
- solr is defined as the statefulsets with only one replication.
- cofiguration files are added as part of configMap objects.
- templatized storage requirements so that it could be deployed to on-prem, eks, minikube clusters.
- Tested this solr chart with ebs and efs as persistent storage.
- sample deploy-values.yaml that can be used to deploy is as follows. These values leverage the EFS as persistent storage for the application.
naveen-armedia
requested review from
JonHolman,
fabricetriboix,
ymuwakki,
jdshinnick and
david-oc-miller
August 8, 2021 15:57
fabricetriboix
suggested changes
Aug 9, 2021
fabricetriboix
suggested changes
Aug 9, 2021
fabricetriboix
previously requested changes
Aug 10, 2021
ymuwakki
reviewed
Aug 11, 2021
ymuwakki
reviewed
Aug 11, 2021
ymuwakki
reviewed
Aug 11, 2021
ymuwakki
approved these changes
Aug 11, 2021
JonHolman
approved these changes
Aug 12, 2021
naveen-armedia
dismissed
fabricetriboix’s stale review
August 12, 2021 15:54
Agreed while on review call to resolve the comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.