Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-blockchain): reset last downloaded block #1692

Merged
merged 2 commits into from
Dec 10, 2018
Merged

fix(core-blockchain): reset last downloaded block #1692

merged 2 commits into from
Dec 10, 2018

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Dec 10, 2018

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@ghost ghost assigned spkjp Dec 10, 2018
@ghost ghost added the review label Dec 10, 2018
@codecov-io
Copy link

codecov-io commented Dec 10, 2018

Codecov Report

Merging #1692 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1692      +/-   ##
===========================================
- Coverage    74.96%   74.95%   -0.01%     
===========================================
  Files          444      444              
  Lines         7962     7963       +1     
  Branches      1048     1048              
===========================================
  Hits          5969     5969              
- Misses        1770     1771       +1     
  Partials       223      223
Impacted Files Coverage Δ
packages/core-blockchain/lib/blockchain.js 75.47% <0%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbdab91...d7a3755. Read the comment docs.

kristjank
kristjank previously approved these changes Dec 10, 2018
@spkjp spkjp changed the base branch from develop to master December 10, 2018 22:05
@spkjp spkjp merged commit 3d7baf9 into ArkEcosystem:master Dec 10, 2018
@ghost ghost removed the review label Dec 10, 2018
spkjp added a commit that referenced this pull request Dec 11, 2018
* fix(core-blockchain): reset lastDownloadedBlock

* chore: changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants