Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-p2p): adjust some ban durations #1730

Merged
merged 2 commits into from
Dec 14, 2018
Merged

Conversation

faustbrian
Copy link
Contributor

Proposed changes

Adjusts some ban durations to make network recovery more stable and take proper advantage of the repeat offender ban.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@ghost ghost assigned faustbrian Dec 14, 2018
@ghost ghost added the review label Dec 14, 2018
@codecov-io
Copy link

codecov-io commented Dec 14, 2018

Codecov Report

Merging #1730 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1730   +/-   ##
========================================
  Coverage    39.49%   39.49%           
========================================
  Files          353      353           
  Lines         7674     7674           
  Branches      1118     1095   -23     
========================================
  Hits          3031     3031           
- Misses        4626     4627    +1     
+ Partials        17       16    -1
Impacted Files Coverage Δ
packages/core-p2p/src/court/offences.ts 100% <ø> (ø) ⬆️
packages/core-test-utils/src/generators/wallets.ts 85.71% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c419ef7...5177c8c. Read the comment docs.

@faustbrian faustbrian merged commit 08558a3 into develop Dec 14, 2018
@faustbrian faustbrian deleted the faustbrian-patch-1 branch December 14, 2018 15:44
@ghost ghost removed the review label Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants