-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: split config into network, milestones, exceptions and dynamic-fees #1733
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1733 +/- ##
===========================================
- Coverage 39.9% 39.76% -0.15%
===========================================
Files 352 354 +2
Lines 7685 7682 -3
Branches 1098 1106 +8
===========================================
- Hits 3067 3055 -12
- Misses 4603 4613 +10
+ Partials 15 14 -1
Continue to review full report at Codecov.
|
@supaiku0 should be ready for review for now. A lot of changes were made some in preparation for hot reloading to make it easier. |
Proposed changes
Sorts out the mess the whole configuration is at the moment by splitting it into network, fees and milestones. This means people no longer need to update their network config anymore.
Dynamic fees are specific to nodes and should not be included in milestones.
Types of changes
Checklist