Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split config into network, milestones, exceptions and dynamic-fees #1733

Merged
merged 68 commits into from
Dec 17, 2018

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Dec 15, 2018

Proposed changes

Sorts out the mess the whole configuration is at the moment by splitting it into network, fees and milestones. This means people no longer need to update their network config anymore.

Dynamic fees are specific to nodes and should not be included in milestones.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@ghost ghost assigned faustbrian Dec 15, 2018
@ghost ghost added the review label Dec 15, 2018
@codecov-io
Copy link

codecov-io commented Dec 15, 2018

Codecov Report

Merging #1733 into develop will decrease coverage by 0.14%.
The diff coverage is 61.08%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1733      +/-   ##
===========================================
- Coverage     39.9%   39.76%   -0.15%     
===========================================
  Files          352      354       +2     
  Lines         7685     7682       -3     
  Branches      1098     1106       +8     
===========================================
- Hits          3067     3055      -12     
- Misses        4603     4613      +10     
+ Partials        15       14       -1
Impacted Files Coverage Δ
packages/core-container/src/registrars/plugin.ts 80.24% <ø> (+0.97%) ⬆️
packages/core-api/src/repositories/transactions.ts 36.58% <ø> (ø) ⬆️
...pto/src/validation/extensions/transactions/base.ts 100% <ø> (ø) ⬆️
packages/core-forger/src/client.ts 78.57% <ø> (ø) ⬆️
packages/crypto/src/models/delegate.ts 78.26% <ø> (ø) ⬆️
packages/core-transaction-pool/src/connection.ts 0% <ø> (ø) ⬆️
...kages/core-api/src/versions/2/peers/transformer.ts 0% <0%> (ø) ⬆️
...kages/core-api/src/versions/1/peers/transformer.ts 0% <0%> (ø) ⬆️
...core-api/src/plugins/validation/formats/address.ts 0% <0%> (ø) ⬆️
...ackages/core-api/src/versions/2/node/controller.ts 0% <0%> (ø) ⬆️
... and 104 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35dbb99...5b73b09. Read the comment docs.

@faustbrian faustbrian changed the title [WIP] refactor: split config into network, milestones and fees refactor: split config into network, milestones and fees Dec 17, 2018
@faustbrian
Copy link
Contributor Author

@supaiku0 should be ready for review for now. A lot of changes were made some in preparation for hot reloading to make it easier.

@faustbrian faustbrian changed the title refactor: split config into network, milestones and fees refactor: split config into network, milestones, exceptions and dynamic-fees Dec 17, 2018
@ghost ghost assigned spkjp Dec 17, 2018
@faustbrian faustbrian merged commit 9a76d4c into develop Dec 17, 2018
@ghost ghost removed the review label Dec 17, 2018
@faustbrian faustbrian deleted the feat/milestones branch December 17, 2018 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants