Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-webhooks): push job when conditions array is empty #1869

Merged
merged 5 commits into from
Dec 19, 2018
Merged

fix(core-webhooks): push job when conditions array is empty #1869

merged 5 commits into from
Dec 19, 2018

Conversation

vmunich
Copy link
Contributor

@vmunich vmunich commented Dec 19, 2018

Proposed changes

Fixes #1868

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@codecov-io
Copy link

codecov-io commented Dec 19, 2018

Codecov Report

Merging #1869 into develop will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1869   +/-   ##
========================================
  Coverage    39.44%   39.44%           
========================================
  Files          350      350           
  Lines         7558     7558           
  Branches      1089     1089           
========================================
  Hits          2981     2981           
  Misses        4565     4565           
  Partials        12       12
Impacted Files Coverage Δ
packages/core-webhooks/src/manager.ts 34.48% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 066d1a7...9daadd7. Read the comment docs.

@faustbrian faustbrian changed the title fix: push job when conditions array is empty fix(core-webhooks): push job when conditions array is empty Dec 19, 2018
@ghost ghost assigned faustbrian Dec 19, 2018
@ghost ghost added the review label Dec 19, 2018
@faustbrian faustbrian merged commit 9d06e55 into ArkEcosystem:develop Dec 19, 2018
@ghost ghost removed the review label Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants