Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core-database-postgres): use token in database name #1992

Merged
merged 9 commits into from
Jan 18, 2019
Merged

chore(core-database-postgres): use token in database name #1992

merged 9 commits into from
Jan 18, 2019

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Jan 16, 2019

Proposed changes

#1970 changed the default name to core_${network}. This PR changes this to $token_$network so we get ark_devnet, etc. like before. It also ensures the names are distinct between different chains.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@spkjp spkjp requested a review from faustbrian January 16, 2019 20:44
@codecov-io
Copy link

codecov-io commented Jan 16, 2019

Codecov Report

Merging #1992 into develop will decrease coverage by <.01%.
The diff coverage is 25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1992      +/-   ##
===========================================
- Coverage    70.04%   70.03%   -0.01%     
===========================================
  Files          385      385              
  Lines         8309     8311       +2     
  Branches      1184     1194      +10     
===========================================
+ Hits          5820     5821       +1     
- Misses        2454     2456       +2     
+ Partials        35       34       -1
Impacted Files Coverage Δ
packages/core-container/src/container.ts 48.78% <0%> (-0.61%) ⬇️
packages/core-container/src/environment.ts 80% <100%> (+0.83%) ⬆️
packages/core-logger-winston/src/formatter.ts 38.88% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa0718e...7d8bb3c. Read the comment docs.

Copy link
Contributor

@faustbrian faustbrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a bash script in the scripts folder that can generate the docker files with the correct names.

@faustbrian faustbrian merged commit ea4f775 into ArkEcosystem:develop Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants