-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(core-database-postgres): use token in database name #1992
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1992 +/- ##
===========================================
- Coverage 70.04% 70.03% -0.01%
===========================================
Files 385 385
Lines 8309 8311 +2
Branches 1184 1194 +10
===========================================
+ Hits 5820 5821 +1
- Misses 2454 2456 +2
+ Partials 35 34 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a bash script in the scripts
folder that can generate the docker files with the correct names.
Proposed changes
#1970 changed the default name to
core_${network}
. This PR changes this to$token_$network
so we getark_devnet
, etc. like before. It also ensures the names are distinct between different chains.Types of changes
Checklist