-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(crypto): implement error classes #2038
Conversation
@faustbrian Thanks for submitting this pull request, a maintainer will get back to you shortly! |
@faustbrian @alexbarnsley @supaiku0 - please review this pull request in the next few days. Be sure to explicitly select labels so I know what's going on. If no reviewer appears after a week, a reminder will be send out. |
@faustbrian The ci/circleci: test-node11-2 job is failing as of a63996a72a3cd46b516899eed2c7fce15143e94f. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
Codecov Report
@@ Coverage Diff @@
## develop #2038 +/- ##
==========================================
+ Coverage 73.69% 73.8% +0.11%
==========================================
Files 366 367 +1
Lines 8223 8258 +35
Branches 1177 1174 -3
==========================================
+ Hits 6060 6095 +35
+ Misses 2131 2129 -2
- Partials 32 34 +2
Continue to review full report at Codecov.
|
Proposed changes
Resolves #2028.
The crypto package now throws specific errors for specific issues rather then a generic
Error
. This allows us to assert types of errors in tests and the application itself rather then fiddling with the string messages of the generic error.All of those errors extend the
CryptoError
class which is generic within the crypto package but still allows us to identify that the error came from the crypto package rather then guessing what happened.Tests have been adjusted to assert instances of errors rather then messages.
Types of changes
Checklist