fix(core-p2p): return an empty array if the peers cache parsing fails #2061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@supaiku0 @air1one - please review this in the next few days. Be sure to explicitly select labels so I know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
Codecov Report
@@ Coverage Diff @@
## develop #2061 +/- ##
===========================================
- Coverage 73.76% 73.76% -0.01%
===========================================
Files 367 367
Lines 8257 8259 +2
Branches 1208 1208
===========================================
+ Hits 6091 6092 +1
- Misses 2132 2133 +1
Partials 34 34
Continue to review full report at Codecov.
|
spkjp
approved these changes
Feb 4, 2019
ghost
deleted the
vasild
added a commit
that referenced
this pull request
Feb 4, 2019
…peer-state * ArkEcosystem/core/develop: fix(core-p2p): return an empty array if the peers cache parsing fails (#2061)
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
If the
~/.cache/ark-core/devnet/peers.jsonfile is malformed theJSON.parsewill fail as only Joi errors are currently handled.Types of changes
Checklist