Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-api): configuration endpoint does not show dynamic fees #2082

Merged
merged 4 commits into from
Feb 12, 2019
Merged

fix(core-api): configuration endpoint does not show dynamic fees #2082

merged 4 commits into from
Feb 12, 2019

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Feb 11, 2019

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@ghost
Copy link

ghost commented Feb 11, 2019

@air1one @faustbrian - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost requested a review from air1one February 11, 2019 18:24
@codecov-io
Copy link

codecov-io commented Feb 11, 2019

Codecov Report

Merging #2082 into develop will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2082      +/-   ##
===========================================
- Coverage    78.54%   78.53%   -0.01%     
===========================================
  Files          331      331              
  Lines         7740     7742       +2     
  Branches      1091     1075      -16     
===========================================
+ Hits          6079     6080       +1     
  Misses        1630     1630              
- Partials        31       32       +1
Impacted Files Coverage Δ
...ackages/core-api/src/versions/2/node/controller.ts 72% <50%> (-1.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67c8557...23af07a. Read the comment docs.

@faustbrian faustbrian merged commit ad5aafd into ArkEcosystem:develop Feb 12, 2019
@ghost ghost removed the Status: Needs Review label Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants