Skip to content

Commit

Permalink
2.2.024
Browse files Browse the repository at this point in the history
  • Loading branch information
nossr50 committed Nov 5, 2024
1 parent 04007f6 commit 406a7ba
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
7 changes: 4 additions & 3 deletions Changelog.txt
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
Version 2.2.024
Fixed a bug where Giga Drill breaker was giving out more loot than intended
Fixed errors when Fishing or using Shake ability
Significant optimizations made to reading new chunks for mcMMO
Significant optimizations to most block interactions in mcMMO code
Fixed a horrendous edge case where Tree Feller could cause a lot of lag

Notes:
Got a bit carried away and started to optimize stuff.
I was able to make Tree Feller way faster with optimizations in this update, I tested with a custom gigantic tree that had over 200,000 blocks felled (huge) and it only took 4 seconds total, in the previous version of mcMMO this would take over 2-3 minutes.
Part of this update focused on optimization, there's improvements of around 30% in CPU time for most code involving block interactions in mcMMO, which happens to be most code in mcMMO.
One of the optimizations made in this update removes an edge case where Tree Feller could cause a lot of lag, but the optimizations really are across the board in regards to any abilities that interact with blocks.

Version 2.2.023
Compatibility with Minecraft 1.21.3
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>com.gmail.nossr50.mcMMO</groupId>
<artifactId>mcMMO</artifactId>
<version>2.2.024-SNAPSHOT</version>
<version>2.2.024</version>
<name>mcMMO</name>
<url>https://github.com/mcMMO-Dev/mcMMO</url>
<scm>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ public void excavationBlockCheck(BlockState blockState) {
excavationBlockCheck(blockState.getBlock());
}


public void excavationBlockCheck(Block block) {
int xp = ExperienceConfig.getInstance().getXp(PrimarySkillType.EXCAVATION, block.getType());
requireNonNull(block, "excavationBlockCheck: block cannot be null");
Expand Down Expand Up @@ -135,6 +134,7 @@ public void printExcavationDebug(Player player, Block block) {
*/
public void gigaDrillBreaker(Block block) {
excavationBlockCheck(block);
excavationBlockCheck(block);

SkillUtils.handleDurabilityChange(getPlayer().getInventory().getItemInMainHand(),
mcMMO.p.getGeneralConfig().getAbilityToolDamage());
Expand Down

0 comments on commit 406a7ba

Please sign in to comment.