Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question service improvements #351

Merged
merged 10 commits into from
Apr 28, 2024
Merged

Question service improvements #351

merged 10 commits into from
Apr 28, 2024

Conversation

PabloGOP
Copy link
Contributor

Include main issues explained in #332, added french templates and improved the questions json simplifying the diferent languages.

@PabloGOP PabloGOP added the question service❔ Related to the question service label Apr 28, 2024
@PabloGOP PabloGOP requested review from uo288347 and uo288543 April 28, 2024 17:27
@PabloGOP PabloGOP self-assigned this Apr 28, 2024
Copy link

sonarqubecloud bot commented Apr 28, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
61.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@uo288543 uo288543 merged commit 2e258c7 into develop Apr 28, 2024
2 of 3 checks passed
@PabloGOP
Copy link
Contributor Author

Pleading to the GitHub Gods: Redemption for Test Coverage

Oh, benevolent gods of GitHub, grant me thy mercy as I beseech thee with fervor! Though my code stands at a coverage of 61.5%, just shy of the required threshold by a mere 18.5%, I implore thee to forgive my shortfall. May my unit tests be strengthened, my codebase fortified, and may I find favor in thy repositories once more. Amen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question service❔ Related to the question service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants