get_curl_resource() check for object instead of resource in PHP 8 #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in PHP 8.0 curl_init() is not returning a resource as stated in docs. As a workaround, check for object instead of resource.
|
Thanks for your contribution. This change does however break the client class for all PHP versions lower than 8 which isn't a good idea 😉 Instead, I'll change that statement to test for either an object or a resource. Will be included with the next release. |
Well, it's working for me also in version 7 :) |
|
FYI; I quickly tested this on 7.2.5. |
You are correct. I'm in 7.4 but maybe i've mismatched something. Thank you. |
|
Thanks, NP. |
malle-pietje
added a commit
that referenced
this pull request
Dec 10, 2020
- added several monthly stats methods: `stat_monthly_gateway()`, `stat_monthly_site()`, `stat_monthly_aps()`, `stat_monthly_user()`, thanks go to @Roel Janssens for spotting these MongoDB collections - test for `object` or `resource` in `get_curl_resource()`, closes PR #82 submitted by @banakito - applied change to comments in `example/modify_smartpower_pdu_outlet.php` based on a suggestion by @thesohoguy - removed unnecessary variable from `list_apgroups()`, thanks go to Stephen Davies for reporting - added an optional parameter $ap_group_ids to the `create_wlan()` function/method for UniFi controller versions 6.0.X and higher, thanks go to Stephen Davies for contributing
|
Merged with 1.1.62 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in PHP 8.0 curl_init() do not return a resource but a CurlHandle object
As a workaround, check for object instead of resource in get_curl_resource()