Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wheee-factor #52

Merged
merged 39 commits into from
Feb 1, 2015
Merged

Wheee-factor #52

merged 39 commits into from
Feb 1, 2015

Conversation

slothelle
Copy link
Member

closes #41
closes #44
closes #45

big refactor to create Yarn, Needle, CustomHatPattern, YarnShown, FinishedSize, Ravelry objects.

@slothelle
split custom controllers into separate file
0123d8a
@slothelle
pass customized and custom size through ngDialog to directive
2a03970
@slothelle
remove unnecessary calculator dependency injection
6a8b415
@slothelle
calculator dependency injection
002b779
@slothelle
remove ng-hide customized
4fd0180
@slothelle
add cast on, hatCalculator
67e73da
@slothelle
remove custom logic from controller into directive, add broadcast for…
1c8f3ef 
… change
@slothelle
remove bugger 🐛 lol
2f5c1ec
@slothelle
notes for future me
957935e
@slothelle
move babyDecreases() onto scope for public use
581a82e
@slothelle
Needle and needleLibrary
42f47a1
@slothelle
needle library in forest park
38dc5d9
@slothelle
winter sea uses needle library
87edf57
@slothelle
remove .0 on non floating sizes
a1c90b7
@slothelle
add space to circular()
7071bba
@slothelle
very pdx uses Needle
97ae627
@slothelle
app.library_services -> library.needle
b7b1dd0
@slothelle
spacing in string
b696b32
@slothelle
Yarn, yarnLibrary
b811385
@slothelle
materials template expects yarn objects
13187ee
@slothelle
winter sea uses Yarn
6acb3e5
@slothelle
label -> weight
9752d60
@slothelle
very pdx uses Yarn; template adjustments for yarn iteration
e080841
@slothelle
factory - CustomHatPattern
2f1db39
@slothelle
babyDecreases() -> custom.babyDecreases()
17207ec
@slothelle
extrapolate most of the work for custom hats out of the directive and…
6c441da 
… into the factory
@slothelle
add label and yardage into Yarn
b4a6df3
@slothelle
move properties to Yarn
37c9066
@slothelle
versions service
b5e058c
@slothelle
rename custom hat pattern factory, versions
7652044
slothelle pushed a commit that referenced this pull request Feb 1, 2015
Merge pull request #52 from ArtCraftCode/wheee-factor
5522bd6 
Wheee-factor
@slothelle slothelle merged commit 5522bd6 into master Feb 1, 2015
@slothelle slothelle deleted the wheee-factor branch February 1, 2015 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
1 participant
@slothelle