Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iter1 #1

Merged
merged 20 commits into from
Aug 7, 2023
Merged

Iter1 #1

merged 20 commits into from
Aug 7, 2023

Conversation

ArtemShalinFe
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2023

Codecov Report

Patch coverage: 52.76% and project coverage change: -24.52% ⚠️

Comparison is base (9b6e50b) 77.27% compared to head (10a9352) 52.76%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           master       #1       +/-   ##
===========================================
- Coverage   77.27%   52.76%   -24.52%     
===========================================
  Files           2        9        +7     
  Lines          22      724      +702     
===========================================
+ Hits           17      382      +365     
- Misses          5      304      +299     
- Partials        0       38       +38     
Files Changed Coverage Δ
internal/models/user.go 0.00% <0.00%> (ø)
internal/server/server.go 29.20% <29.20%> (ø)
internal/models/order.go 31.57% <31.57%> (ø)
internal/server/handlers.go 42.91% <42.91%> (ø)
internal/server/jwt.go 66.66% <66.66%> (ø)
internal/security/security.go 72.72% <72.72%> (ø)
internal/server/logger.go 78.94% <78.94%> (ø)
internal/server/mock_handlers.go 85.47% <85.47%> (ø)
internal/config/config.go 88.88% <88.88%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArtemShalinFe ArtemShalinFe requested a review from s-shpak July 18, 2023 05:53
Copy link
Collaborator

@s-shpak s-shpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Поправь, пожалуйста, ворнинги линтера

go.mod Outdated Show resolved Hide resolved
cmd/gophermart/internal/server/mock_handlers.go Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
cmd/gophermart/internal/server/jwt.go Outdated Show resolved Hide resolved
cmd/gophermart/internal/server/jwt_test.go Outdated Show resolved Hide resolved
cmd/gophermart/internal/server/handlers.go Outdated Show resolved Hide resolved
cmd/gophermart/internal/server/handlers.go Outdated Show resolved Hide resolved
cmd/gophermart/internal/db/user.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@s-shpak s-shpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Поправь, пожалуйста, ворнинги линтера

go.mod Outdated Show resolved Hide resolved
cmd/gophermart/internal/server/mock_handlers.go Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
cmd/gophermart/internal/adapters/accrual.go Outdated Show resolved Hide resolved
cmd/gophermart/main.go Outdated Show resolved Hide resolved
cmd/gophermart/internal/adapters/accrual.go Outdated Show resolved Hide resolved
cmd/internal/adapters/accrual.go Outdated Show resolved Hide resolved
cmd/gophermart/internal/adapters/accrual.go Outdated Show resolved Hide resolved
cmd/internal/server/handlers.go Outdated Show resolved Hide resolved
cmd/gophermart/internal/adapters/accrual.go Outdated Show resolved Hide resolved
@ArtemShalinFe ArtemShalinFe merged commit dc9412f into master Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants