Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scanner: Delete Missing files #50

Merged
merged 2 commits into from
Apr 6, 2024
Merged

Conversation

Arthi-chaud
Copy link
Owner

@Arthi-chaud Arthi-chaud commented Apr 6, 2024

Closes #32
Closes #34

@Arthi-chaud Arthi-chaud added the scanner About the Scanner Microservice label Apr 6, 2024
@Arthi-chaud Arthi-chaud self-assigned this Apr 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 19.48%. Comparing base (7665d4b) to head (5dd76fc).

Files Patch % Lines
scanner/pkg/api/api.go 0.00% 21 Missing ⚠️
scanner/pkg/actions/delete.go 0.00% 12 Missing ⚠️
scanner/pkg/watcher/handle_event.go 0.00% 3 Missing ⚠️
scanner/app/main.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
- Coverage   20.65%   19.48%   -1.17%     
==========================================
  Files          12       12              
  Lines         552      585      +33     
==========================================
  Hits          114      114              
- Misses        438      471      +33     
Flag Coverage Δ
scanner 19.48% <0.00%> (-1.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Arthi-chaud Arthi-chaud changed the title Scanner: Delete Missing files on Startup Scanner: Delete Missing files Apr 6, 2024
@Arthi-chaud Arthi-chaud merged commit 099543d into main Apr 6, 2024
12 checks passed
@Arthi-chaud Arthi-chaud deleted the scanner/delete-file-on-startup branch April 17, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scanner About the Scanner Microservice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scanner: Handle File Deletion Scanner: On startup, delete the missing files
2 participants