Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artist Page + Make project ready for prod #69

Merged
merged 15 commits into from
May 9, 2024
Merged

Conversation

Arthi-chaud
Copy link
Owner

No description provided.

@Arthi-chaud Arthi-chaud added front About the Front App scanner About the Scanner Microservice matcher The External Metadata Matcher labels May 9, 2024
@Arthi-chaud Arthi-chaud self-assigned this May 9, 2024
@Arthi-chaud Arthi-chaud force-pushed the front/artist-page branch 2 times, most recently from 5340a8a to 24fd2d4 Compare May 9, 2024 15:19
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 25.84%. Comparing base (f0ad7d0) to head (28a5d0d).

Files Patch % Lines
scanner/pkg/actions/register.go 0.00% 3 Missing ⚠️
scanner/pkg/parser/media_info.go 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   17.32%   25.84%   +8.51%     
==========================================
  Files          13       16       +3     
  Lines         658      801     +143     
  Branches        0        7       +7     
==========================================
+ Hits          114      207      +93     
- Misses        544      587      +43     
- Partials        0        7       +7     
Flag Coverage Δ
matcher 65.03% <ø> (?)
scanner 17.32% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Arthi-chaud Arthi-chaud merged commit 630587e into main May 9, 2024
25 checks passed
@Arthi-chaud Arthi-chaud deleted the front/artist-page branch May 9, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front About the Front App matcher The External Metadata Matcher scanner About the Scanner Microservice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants