Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scanner: Handle edge case for chapters parsing #70

Merged
merged 1 commit into from
May 9, 2024

Conversation

Arthi-chaud
Copy link
Owner

No description provided.

@Arthi-chaud Arthi-chaud added bug Something isn't working scanner About the Scanner Microservice labels May 9, 2024
@Arthi-chaud Arthi-chaud self-assigned this May 9, 2024
@Arthi-chaud Arthi-chaud force-pushed the scanner/chapter-parsing-edge-case branch from 354af06 to 67d121f Compare May 9, 2024 16:28
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 17.06%. Comparing base (630587e) to head (67d121f).

Files Patch % Lines
scanner/pkg/parser/media_info.go 0.00% 14 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
- Coverage   25.84%   17.06%   -8.78%     
==========================================
  Files          16       13       -3     
  Lines         801      668     -133     
  Branches        7        0       -7     
==========================================
- Hits          207      114      -93     
+ Misses        587      554      -33     
+ Partials        7        0       -7     
Flag Coverage Δ
matcher ?
scanner 17.06% <0.00%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Arthi-chaud Arthi-chaud merged commit 7720660 into main May 9, 2024
25 checks passed
@Arthi-chaud Arthi-chaud deleted the scanner/chapter-parsing-edge-case branch May 9, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working scanner About the Scanner Microservice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants