Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gui #211

Merged
merged 1 commit into from
Jan 12, 2024
Merged

fix gui #211

merged 1 commit into from
Jan 12, 2024

Conversation

mzlogin
Copy link
Contributor

@mzlogin mzlogin commented Jun 27, 2023

The unit of width option in Tkinter Entry widget is text units but not pixels, so in some environment, the input Entry may overflow the window. Just remove width to make it self-adaption.

before:

before

after:

after

@jamie-lemon
Copy link
Collaborator

@dothinking This seems fine to me - any reason not to merge?

@dothinking
Copy link
Contributor

@dothinking This seems fine to me - any reason not to merge?

yes, we can merge it for now.

I'm struggling if to remove this gui feature in the future considering that

any suggestion?

@jamie-lemon
Copy link
Collaborator

Sure - the GUI isn't really that critical , but there is no harm in having it either! :)

@jamie-lemon jamie-lemon merged commit fb6c96a into ArtifexSoftware:master Jan 12, 2024
@dothinking dothinking mentioned this pull request Jan 20, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants