fix: axios expects paramsSerializer (twilio#82)

* fix: axios expects paramsSerializer * add test
AsabuHere · Mar 30, 2020 · 8c55d29 · 8c55d29
1 parent 189e5d9
commit 8c55d29
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/services/cli-http-client.js b/src/services/cli-http-client.js
@@ -78,7 +78,7 @@ class CliRequestClient {
 
     if (opts.params) {
       options.params = opts.params;
-      options.paramSerializer = params => {
+      options.paramsSerializer = params => {
         return qs.stringify(params, { arrayFormat: 'repeat' });
       };
     }

diff --git a/test/services/cli-http-client.test.js b/test/services/cli-http-client.test.js
@@ -48,5 +48,21 @@ describe('services', () => {
         const request = client.request({ method: 'GET', uri: 'https://foo.com/bar' });
         await expect(request).to.be.rejectedWith(TwilioCliError);
       });
+
+    test
+      .nock('https://foo.com', api => {
+        api.get('/bar?foo=bar&foo=baz').reply(200);
+      })
+      .it('correctly serializes array parameters', async () => {
+        const client = new CliRequestClient('bleh', logger);
+        const response = await client.request({
+          method: 'GET',
+          uri: 'https://foo.com/bar',
+          params: {
+            foo: ['bar', 'baz']
+          }
+        });
+        expect(response.statusCode).to.equal(200);
+      });
   });
 });