Relax oauth2 dependency #138
Conversation
|
@jv-asana Could you review this? |
stanhu
force-pushed
the
sh-loosen-oauth2-dep
branch
from
00a3ee8
to
ac59f02
Compare
oauth2 v2.0 is out now. This gem appears to be fully compatible, so loosen the dependency to allow for 2.0.
stanhu
force-pushed
the
sh-loosen-oauth2-dep
branch
from
ac59f02
to
50ebb3f
Compare
| multi_xml (~> 0.5) | ||
| rack (>= 1.2, < 3) | ||
| rash_alt (>= 0.4, < 1) |
There was a problem hiding this comment.
Hi @stanhu, the oauth2 relaxation looks good. But what are these other gems used for? (rash_alt , version_gem, hashie). I just want to understand the use case.
There was a problem hiding this comment.
These are all dependencies or sub-dependencies introduced in oauth2 v2.0.0. For example:
oauth-xx/oauth2#575
version_gem came from oauth-xx/oauth2@23c4db5 (https://github.com/pboling/version_gem).
There was a problem hiding this comment.
Oh I see now. LGTM. Will approve and merge
There was a problem hiding this comment.
@jv-asana Thanks! Would appreciate a new tag since this is the one gem that is holding us back from being able to upgrade oauth2.
There was a problem hiding this comment.
@stanhu done. Hope this unblocks you :)
oauth2 v2.0 is out now. This gem appears to be fully compatible, so loosen the dependency to allow for 2.0.