BaseEloquentRepository allWithBuilder() Error

[darron1217]

Summary of issue

Type error: Return value of Modules\Core\Repositories\Eloquent\EloquentBaseRepository::allWithBuilder() must be an instance of Illuminate\Database\Eloquent\Builder, instance of Modules\{ModuleName}\Entities\{ModelName} returned

{ModuleName} and {ModelName} is just sample name.

I got an error while calling allWithBuilder() of my own repository. (Which extends BaseRepository without any overriding)

I looked into the error and I found that this method returns return $this->model;
Just like the link below

Platform/Modules/Core/Repositories/Eloquent/EloquentBaseRepository.php

Line 62 in 9f9c4c4

return $this->model;

Maybe we should change this method into return $this->model->query(); to avoid error

Steps to reproduce

System Details

• Operating System
• PHP Version
• Laravel Version
• Asgardcms/Platform version

[nWidart]

Hm interesting, this worked before.

Indeed I think the query() method does return the correct type.

[darron1217]

@nWidart I think if we use Translatable Model, we can avoid this error.
I was using it well too :)

        if (method_exists($this->model, 'translations')) {
            return $this->model->with('translations');
        }