Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only swipe to remove artile with unread filter #520

Merged

Conversation

aeghn
Copy link
Contributor

@aeghn aeghn commented Jan 12, 2024

(cherry picked from commit c35fe96)

@mbestavros
Copy link
Collaborator

@aeghn Could you elaborate on what this change is supposed to do? I tried the swipe to dismiss gesture, and it worked in both "All" and "Unread" feeds with your patch applied.

@nvllz
Copy link
Contributor

nvllz commented Jan 12, 2024

@mbestavros it's about not dismissing articles in "All" and "Starred" Flow pages. So you can dismiss it from "Unread" Flow, but as it's still supposed to be shown in "All", it's only marked as read instead of disappearing when you swipe on some article from there. I've been using a custom build with this code for months and can confirm it works well.

@mbestavros
Copy link
Collaborator

mbestavros commented Jan 17, 2024

@nvllz I don't know what I did to test it last time, but when revisiting it now, it works perfectly, just as described. And the new behavior applies to every view within the "All" tab (ie. all articles, a category, and an individual feed), which is what we want.

Let's merge it! Thanks for the contribution @aeghn!

@mbestavros mbestavros merged commit 2b43ce2 into Ashinch:main Jan 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants