fix: remove crafting items in non-input slots

AsoDesu · Apr 20, 2024 · 8b30a9f · 8b30a9f
1 parent 245be43
commit 8b30a9f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/main/java/net/asodev/islandutils/modules/crafting/CraftingUI.java b/src/main/java/net/asodev/islandutils/modules/crafting/CraftingUI.java
@@ -31,7 +31,10 @@ public static CraftingMenuType craftingMenuType(Component component) {
 
     private static TextColor timeLeftColor = ChatUtils.parseColor("#FF5556");
     public static void analyseCraftingItem(CraftingMenuType type, ItemStack item, int slot) {
-        if (!isInputSlot(slot)) return;
+        if (!isInputSlot(slot)) {
+            CraftingItems.removeSlot(type, slot);
+            return;
+        }
 
         List<Component> lores = Utils.getLores(item);
         if (lores != null && isActive(lores)) {

diff --git a/src/main/java/net/asodev/islandutils/modules/crafting/state/CraftingItems.java b/src/main/java/net/asodev/islandutils/modules/crafting/state/CraftingItems.java
@@ -45,8 +45,8 @@ public static void addItem(CraftingItem item) {
      * @param slot The slot you wish to remove
      */
     public static void removeSlot(CraftingMenuType type, int slot) {
-        items.removeIf(i -> i.getCraftingMenuType() == type && i.getSlot() == slot);
-        save();
+        boolean wasRemoved = items.removeIf(i -> i.getCraftingMenuType() == type && i.getSlot() == slot);
+        if (wasRemoved) save();
     }
 
     public static <T> void submit(Runnable task) {
@@ -84,7 +84,7 @@ public static void saveSync() {
                 try {
                     array.add(item.toJson());
                 } catch (Exception e) {
-                    logger.error("Failed to save item: " + item, e);
+                    logger.error("Failed to save item: {}", item, e);
                 }
             }