Add Spanish i18n file #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great ! Thanks @davidjr82 for your contribution! new release (with your work): 1 missing translation: "Switch to spanish" (the title attribute in language menu) ---> fixed by #158 and some change in "All details about the contrast ratio" section ---> fixed by #158 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I verified my work is based on
developbranchPurpose of this Pull Request?
Translate it to spanish (in fact it should be es_ES - European Spanish)
Where should the reviewer start its review?
File "webapp/src/main/resources/i18n/contrast-finder_utf8_es.properties" has been added.
How the PR could be tested?
Test the site using Spanish file language. Check everything works.
Any background context you want to provide?
This PR hasn't been tested in localhost, so hopefully it doesn't break anything. Afterwards, I will review the site in Spanish to check that everything has sense or change any translation if any concepto fits better.
What are the related issues?
No issue has been opened. Help offered in twitter.
Screenshots (if appropriate)
No needed.
(by the way, thank you very much for contributing to Contrast-Finder!)
(It has been a pleasure. As I said, I think developers need to start adopting accesibility by default in our work, and I think we must support this kind of tools.)