fix: Support trailing comma in function type parameters (#2608)

AssemblyScript · Jan 6, 2023 · 1ff71e5 · 1ff71e5
1 parent 4b3b390
commit 1ff71e5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 0 deletions.
diff --git a/src/parser.ts b/src/parser.ts
@@ -797,6 +797,7 @@ export class Parser extends DiagnosticEmitter {
           }
         } else {
           if (isSignature) {
+            if (tn.peek() == Token.CloseParen) break; // allow trailing comma
             this.error(
               DiagnosticCode.Identifier_expected,
               tn.range()

diff --git a/tests/parser/function-type.ts b/tests/parser/function-type.ts
@@ -3,3 +3,4 @@ var b: (a: i32, b: i32) => void;
 var c: (a: i32, b: i32) => (a: i32, b: i32) => void;
 var d: (a: i32, a: i32) => void; // NOTE: duplicates in type signatures doesn't in TypeScript
 var e: (a) => void; // TS1110
+var f: (a: i32, b: i32,) => (a: i32, b: i32,) => void;
diff --git a/tests/parser/function-type.ts.fixture.ts b/tests/parser/function-type.ts.fixture.ts
@@ -3,4 +3,5 @@ var b: (a: i32, b: i32) => void;
 var c: (a: i32, b: i32) => (a: i32, b: i32) => void;
 var d: (a: i32, a: i32) => void;
 var e: (a) => void;
+var f: (a: i32, b: i32) => (a: i32, b: i32) => void;
 // ERROR 1110: "Type expected." in function-type.ts(5,10+0)