Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ts-node to 8.6.2 #1168

Closed
wants to merge 1 commit into from
Closed

update ts-node to 8.6.2 #1168

wants to merge 1 commit into from

Conversation

MaxGraey
Copy link
Member

@MaxGraey
Copy link
Member Author

btw ts-node was included in devDependencies and dependencies

@MaxGraey MaxGraey requested a review from dcodeIO March 14, 2020 06:55
@dcodeIO
Copy link
Member

dcodeIO commented Mar 14, 2020

update ts-node to 8.6.2

Last time i checked upgrading to >6 led to subtle errors as described here. Wondering if that's not an issue anymore?

btw ts-node was included in devDependencies and dependencies

The duplicates are intentional as an indicator that these are needed on npm install AssemblyScript/assemblyscript, but not on npm install assemblyscript. Handled by prepublish.

@MaxGraey
Copy link
Member Author

Last time i checked upgrading to >6 led to subtle errors as described here.

Not sure, but you could check this. I didn't see any errors

@dcodeIO dcodeIO mentioned this pull request Mar 14, 2020
Merged
@dcodeIO
Copy link
Member

dcodeIO commented Mar 14, 2020

Fixed by #1170

@dcodeIO dcodeIO closed this Mar 14, 2020
@MaxGraey MaxGraey deleted the update-ts-node branch March 15, 2020 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO Awaiting requested review from dcodeIO

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxGraey @dcodeIO