Fix various issues with object literals #1235
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #1229 that fixes various issues unrelated to that PR. In particular, classes instantiated from object literals cannot declare a constructor anymore since all kinds of stuff can go wrong with custom logic, with the most prominent one being that we don't know what fields the constructor sets (yet, there's PR for that), in the worst case overwriting those fields with
null
s again. The upside is that we can rely on generated constructors for the time being, so field initializers of omitted fields can be applied, fixing the commented out test.