-
-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update binaryen #2547
Update binaryen #2547
Conversation
MaxGraey
commented
Nov 2, 2022
- I've read the contributing guidelines
- I've added my name and email to the NOTICE file
Co-authored-by: dcode <dcode@dcode.io>
@@ -10,6 +10,7 @@ | |||
(data (i32.const 1036) "\1c") | |||
(data (i32.const 1048) "\02\00\00\00\02\00\00\00a") | |||
(table $0 1 1 funcref) | |||
(elem $0 (i32.const 1)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea what's going on here? Seems strange that this affects just a few release tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea. Perhaps a some regression in Binaryen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
debug fixture contains this:
(elem $0 (i32.const 1)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to remove new "reorder-globals" pass, but this didn't help
Would it be good to make the pass pipeline change still? :) |