Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update this and return type in child class constructor #2574 #2635

Merged
merged 3 commits into from
Jan 31, 2023
Merged

fix: update this and return type in child class constructor #2574 #2635

merged 3 commits into from
Jan 31, 2023

Conversation

HerrCai0907
Copy link
Member

@HerrCai0907 HerrCai0907 commented Jan 28, 2023 •
edited
Loading

When use parent constructor as child default constructor, function signature should update thisType and returnType instead of directly using parent constructor

@HerrCai0907 HerrCai0907 requested a review from dcodeIO January 30, 2023 07:47
@dcodeIO dcodeIO merged commit 941b0e1 into AssemblyScript:main Jan 31, 2023
@dcodeIO dcodeIO mentioned this pull request Jan 31, 2023
Closed
@dcodeIO
Copy link
Member

dcodeIO commented Jan 31, 2023

Thanks! I guess this fixes #2574?

@HerrCai0907 HerrCai0907 deleted the fix/2574 branch January 31, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxGraey MaxGraey MaxGraey left review comments

@dcodeIO dcodeIO dcodeIO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HerrCai0907 @dcodeIO @MaxGraey