Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Binaryen to fix #2810 #2811

Merged
merged 1 commit into from
Jan 14, 2024
Merged

Conversation

CountBleck
Copy link
Member

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

src/module.ts Show resolved Hide resolved
src/module.ts Show resolved Hide resolved
This version of binaryen.js has the requisite 4 GiB max memory change.
Fixes AssemblyScript#2810.
@dcodeIO
Copy link
Member

dcodeIO commented Jan 14, 2024

The global access changes seem interesting, btw. Not sure if Binaryen no longer optimizes these to cache to locals, or undoes what the compiler already does on purpose. If it's the former, then perhaps there are new configuration options (to achieve the same as before), and if it's the latter, we might simplify emitted code.

@CountBleck
Copy link
Member Author

It looks like (from my limited testing) there's some smarter threshold that isn't "some variable being accessed a bunch of times". I'll try to look into it further.

@MaxGraey
Copy link
Member

he global access changes seem interesting, btw

Binaryen doesn't optimize simple global access anymore: WebAssembly/binaryen#6087

@CountBleck
Copy link
Member Author

@dcodeIO is there any particular reason one might prefer the old behavior?

@CountBleck
Copy link
Member Author

@dcodeIO Do I have the green light to merge?

@CountBleck CountBleck merged commit dc547a8 into AssemblyScript:main Jan 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants