Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore this #2834

Merged
merged 1 commit into from
Apr 3, 2024
Merged

fix: ignore this #2834

merged 1 commit into from
Apr 3, 2024

Conversation

CountBleck
Copy link
Member

This is a dummy commit to create a new release.

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

This is a dummy commit to create a new release.
@CountBleck CountBleck merged commit b640ff2 into AssemblyScript:main Apr 3, 2024
13 checks passed
@CountBleck CountBleck deleted the empty branch April 3, 2024 03:19
@HerrCai0907
Copy link
Member

Do you know why our release pipeline does not work?

@HerrCai0907
Copy link
Member

I found the reason, aspublish requires breaking / feat / fix prefix to identifier the version upgrade. Maybe we need to create an action and check the PR title to avoid this weird empty PR. WDYT?

@CountBleck
Copy link
Member Author

@HerrCai0907 That would be nice, but if a PR only has one commit, the default commit title in the merge commit is based off of that commit's title, not the PR title (see #2826).

@HerrCai0907
Copy link
Member

@HerrCai0907 That would be nice, but if a PR only has one commit, the default commit title in the merge commit is based off of that commit's title, not the PR title (see #2826).

Yes. But we can switch the merge strategy in configuration page. I am not sure who has the access to setup it. Maybe it needs @dcodeIO or @MaxGraey

@CountBleck
Copy link
Member Author

@HerrCai0907 that doesn't sound ideal...

@HerrCai0907
Copy link
Member

Configuration like this:
image

Why is it not ideal?

@dcodeIO
Copy link
Member

dcodeIO commented Apr 4, 2024

Changed the setting to "Pull request title" as suggested

@CountBleck
Copy link
Member Author

CountBleck commented Apr 4, 2024

Why is it not ideal?

@HerrCai0907 Oh I misunderstood (I thought you meant switching away from squash merging). That's perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants