[WIP] Improve Parser #393
Closed
[WIP] Improve Parser #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync from origin
Sync from origin
initial and max memory set to sharedMemory
…hanged to global etc.
… are generated, which includes adding a `;` to a sub expression that is not a block.
…ased-threads-wait-wake-integration Feature/worker based threads wait wake integration
…ipt#355 This only affects static fields that currently must have a type annotation, while it wouldn't work if there wasn't an annotated type, like on normal globals, which aren't compiled lazily, though. Must be revisted if requirements on type annotations on fields ever become relaxed.
This also made it necessary to extend the internal per-function instances map by one level for the respective class instance key so functions on differnt class instances with the same own type arguments don't collide.
…ue at ptr to change.
|
What's the status of this? Does "merging dependencies" address #194? |
|
Yes this would solve that. I have yet to return to this in a while, but my next goal was to use Wasi to make this a portable cli tool. |
|
@willemneal most of changes relate to treading and its examples / tests? I guess it all outdated already. Could we close this? |
Closed
|
Closing this PR as part of 2020 vacuum as it appears to be outdated. I also don't quite understand what's done why and the commit log doesn't seem like it'll be possible to merge, but feel free to refine this and open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving the parser is key to making loading of asc binaries easier. For example, if a
waitornotifyinstruction is used the parser can replace it with a call to an import. Furthermore, it can allow the corresponding host code to be packaged with the binary in a custom section. Lastly and perhaps the most exciting aspect is merging dependencies. Ideally it should be possible to merge an arbitrary wasm binary given that its exports are a subset of the assemblyscript wasm binary's imports.This PR, however, does not seek to replace the binaryen dependency for the compiler, but it is a first step.