Upgrade polkadot v0.9.16 #567
Conversation
| pallet-custom-signatures = { git = "https://github.com/AstarNetwork/astar-frame", tag = "pallet-custom-signatures-4.3.0/polkadot-0.9.13", default-features = false } | ||
| pallet-dapps-staking = { git = "https://github.com/AstarNetwork/astar-frame", tag = "pallet-dapps-staking-1.1.2/polkadot-0.9.13", default-features = false } | ||
| pallet-vesting = { git = "https://github.com/AstarNetwork/astar-frame", tag = "pallet-vesting-4.0.0-dev/polkadot-0.9.13", default-features = false } | ||
| pallet-block-reward = { git = "https://github.com/AstarNetwork/astar-frame", branch = "polkadot-v0.9.16", default-features = false } |
There was a problem hiding this comment.
I really think we shouldn't do this and should go with tags instead.
This will become the new default branch and we have fairly often deliveries there.
There was a problem hiding this comment.
As I can see now, tags isn't so convenient as branches, you can't fork tag easily to provide new polkadot adjusted version.
Other point is to have default branch, if some should be fixed let's use dedicated branches. In situation with tags the new polkadot release is hell.
There was a problem hiding this comment.
We don't need to fork each tag separately - only what's needed.
The majority of pallets we use just take from the default - only Astar dapps-staking is special.
So when doing a polkadot upgrade, we could just:
- create a new branch for the new polkadot version and make this the new default branch
- create just a single new tag
polkadot-a.b.cfor this latest version- once we update a pallet, we can create the new tag as previously agreed
- update runtimes to use this tag UNLESS they require a pallet version that differs from the latest default branch
It's not just about fixes though - the tags are useful for situations like we'll have when I merge individual claim.
Initially only Shibuya will use it - then Shiden - then Astar. I can work freely on the default branch in astar-frame as long as I know that Shiden and Astar don't depend on any branch and they use dapps-staking-x.y.z./polkadot-a.b.c. instead.
| @@ -2,14 +2,14 @@ | |||
| //! Autogenerated weights for `pallet_dapps_staking` | |||
| //! | |||
| //! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 4.0.0-dev | |||
| //! DATE: 2021-10-18, STEPS: `20`, REPEAT: 10, LOW RANGE: `[]`, HIGH RANGE: `[]` | |||
There was a problem hiding this comment.
Not really important but it would be more correct to use the ones from pallet - those were measured on dev chain.
There was a problem hiding this comment.
Let's update it after, please write TODO somewhere.
|
@Dinonard let's discuss tag/branch question on dedicated meeting, may be tomorrow. We can fix in any patch release. |
| pub struct WeightInfo<T>(PhantomData<T>); | ||
| impl<T: frame_system::Config> pallet_dapps_staking::WeightInfo for WeightInfo<T> { | ||
| // Storage: DappsStaking RegisteredDevelopers (r:1 w:1) | ||
| // Storage: DappsStaking RegisteredDapps (r:1 w:1) | ||
| // Storage: DappsStaking PreApprovalIsEnabled (r:1 w:0) | ||
| fn register() -> Weight { | ||
| (63_974_000 as Weight) | ||
| (39_675_000 as Weight) |
There was a problem hiding this comment.
Is there a reason why the block weights changed on the local? I can see the weights are the same as
and this was also executed with theshibuya-dev flag, but just curious why the auto-gen file was assigned to the local runtime 🤔 https://github.com/AstarNetwork/Astar/pull/567/files#diff-3949041c500f115558c821562657ee76c628c7d0c3d8e2a7a82ea34e63eff8c8R12
Pull Request Summary
Check list
This pull request makes the following changes:
Adds
Fixes
Changes
To-dos