Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/polkadot v0.9.33 #795

Merged
merged 16 commits into from
Dec 6, 2022
Merged

Feat/polkadot v0.9.33 #795

merged 16 commits into from
Dec 6, 2022

Conversation

Dinonard
Copy link
Member

@Dinonard Dinonard commented Nov 30, 2022 •
edited
Loading

Pull Request Summary

Uplifts Astar from polkadot-v0.9.30 to polkadot-v0.9.33.
This contains lots of changes, and overview can be read here:

Notable PRs
The following is a condensed list of most impactful PRs.

Check list

  • cleanup duplicated client code (related to old contracts RPC)
  • try-runtime tests for ALL runtimes
  • updated spec version
  • updated semver

@Dinonard Dinonard requested review from shunsukew, akru and 0x7CFE December 2, 2022 10:52
@Dinonard Dinonard marked this pull request as ready for review December 2, 2022 10:52
0x7CFE
0x7CFE approved these changes Dec 6, 2022
View reviewed changes
runtime/local/src/lib.rs
@@ -157,7 +159,7 @@ parameter_types! {
pub const BlockHashCount: BlockNumber = 2400;
/// We allow for 1 seconds of compute with a 2 second average block time.
pub RuntimeBlockWeights: BlockWeights = BlockWeights
::with_sensible_defaults(WEIGHT_PER_SECOND, NORMAL_DISPATCH_RATIO);
::with_sensible_defaults(WEIGHT_PER_SECOND.set_proof_size(u64::MAX), NORMAL_DISPATCH_RATIO);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's irrelevant for non-parachains.

runtime/local/src/lib.rs Outdated Show resolved Hide resolved
runtime/shibuya/src/lib.rs Outdated Show resolved Hide resolved
runtime/shiden/src/lib.rs Outdated Show resolved Hide resolved
@Dinonard Dinonard merged commit 45f954b into master Dec 6, 2022
@Dinonard Dinonard deleted the feat/polkadot-v0.9.33 branch December 6, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x7CFE 0x7CFE 0x7CFE approved these changes

@akru akru akru approved these changes

@shunsukew shunsukew Awaiting requested review from shunsukew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dinonard @akru @0x7CFE